Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more distance_metrics for vector space and also for boolean vector. #190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added more distance_metrics for vector space and also for boolean vector. #190

wants to merge 3 commits into from

Conversation

ShubhamMishra1611
Copy link

Distance metric reference has been taken from here

Added methods to evaluate sEuclidean and Mahalanobis distance and Jaccard,Matching,Dice,Kulsinki,Rogers Tanimoto,Russell Rao Distance,Sokal Michener,Sokal Sneath distance metrics for boolean vector space.

@rohansingh9001
Copy link
Collaborator

Hi Shubham the code LGTM but
can you add the following files to support this PR -

  1. An example file and put it in the examples folder. Nothing much, just demonstrating the use of this metric.
  2. Let me know which issue does it resolve?
  3. Add the features you added in the README.md file so that it is up to date with all the features added with your PR.

@ShubhamMishra1611
Copy link
Author

Added example file along with code formatting and updated README.md file.
The issue was #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShubhamMishra1611 @rohansingh9001